Comments on: Note to CodeIgniter nerds: please, no looping code in your views.

By: Stefan Mischook

Stefan Mischook — Sat, 24 Oct 2009 12:07:32 +0000

“I think the video you speak of is just to demonstrate how to create a basic page. It doesn’t actually use the MVC approach.”

Hi,

I guess you are talking about the CodeIgniter video?

Thanks for the comment.

Stef

By: phil

phil — Sat, 24 Oct 2009 10:05:43 +0000

I’ve just stumbled on this while looking for something else completely – but going back to the initial article:

I think the video you speak of is just to demonstrate how to create a basic page. It doesn’t actually use the MVC approach.

Next, if you don’t want PHP in your view (like me), then just use the parser class and keep all php away from your view.

By: Steve Weiss

Steve Weiss — Thu, 03 Sep 2009 05:56:29 +0000

I have a bone to pick with this one…

My designers all easily understand the concept of a loop. Often times, for various reasons, they need to drop in an extra blank table cell in the middle of every row or toss in a checkbox for this one special thing or they in some other way need to add extra stuff to the table, including manipulating the individual rows.

To be honest, when we try and abstract things out like the author suggests, it’s just like so many here have already said – the designer will come back to you over and over again and ask you to change it. It’s not as simple as you make it out to be. CSS really does not always cut it, especially in a world that still includes IE 6. Maybe if people really do get their act together on some standards, and we get CSS3 and HTML5, and manna falls from the heavens, in a decade, perhaps, but there’s a reality that trumps anything the W3C might want to dream up in this regard. Honestly, even Safari can’t do everything in CSS yet. You simply cannot manipulate a table every which way without getting down to the row-level detail in the HTML – CSS only allows so much – not without nth-child accessors and the like, at least. Building helpers to get around this is needlessly overcomplicated and difficult to explain to designers when they generally easily understand the concept of foreach: endforeach;, and all understand basic HTML. I’m finding it difficult to imagine the designer who can’t get it, and have not had my designers “bust” my code anywhere near as frequently as you’ve suggested. Get SVN, and a deployment system… they shouldn’t be working on your production code anyway. If the site stops working, it’s almost never their fault.

By: Stefan Mischook

Stefan Mischook — Wed, 03 Jun 2009 18:40:06 +0000

“I think if you are an HTML designer, you should have a general (if not excellent) understanding of the server side languages you are working in …”

I agree on this point 100%. That’s why I created Killerphp.com in the first place:

1. To promote PHP as basic skill in web design.
2. To make learning PHP easy for designer types.

Stefan

By: Brian

Brian — Tue, 02 Jun 2009 02:09:46 +0000

I’m not sure if anyone has commented on this subject, but I think this is pretty much a moot point mainly because CodeIgniter has helpers and libraries specifically for HTML generation, such as The Pagination Class, HTML Table Class, Form Helper, and HTML helper, just to name a few. CodeIgniter seems to have a lot of tools available for developers to generate portions of their HTML. I think if you are an HTML designer, you should have a general (if not excellent) understanding of the server side languages you are working in order to be able to make slight modifications if needed without breaking the whole thing (such as adding a class name or ID to something). As a developer, I also think it’s important that you keep things like this in mind as your developing and provide the designer a set of classes and IDs to help make styling the HTML much easier. If you give the designer 1 variable with an entire table of data inside, he’s going to come right back to you for changes or get you to put more code in the view. I think I too agree with a lot of the comments in that a lot of the code needs to go in the controller, but there’s still some that is OK to put in the view. IMO.

By: Andrei

Andrei — Sun, 08 Feb 2009 20:29:24 +0000

Hopefully I’m not too late – I had stumbled upon this discussion while searching for some MVC tuts.

Being a front-end dev/designer (html,css, javascript), I would have to agree with Mr.Murray, and disagree with the author.

You can’t limit designers by saying “this is the output, deal with it.” In a way, you’re practically saying that your way of doing front-end (your html output) is the be-all and end-all of it, and they should simply “beautify” your output.

That’s not the way things work, unfortunately.

Anyone with any extensive experience with CSS and Javascript, and all the ridiculous behaviors that the different browsers throw at you when you are building complex-designed websites, know that it would be a major time-eater to keep giving the PHP developer a call saying that the code’s output needs to be changed to XYZ.

It’s our job to do the front-end: UI, markup, presentation, behaviors, et al; and it’s your job to make things dynamic and manage the data. Most of us – the decent front-end people – can easily understand code. If your front-end people can’t, then it’s time you replaced them.

Honestly, It’s really that simple.

By: Matt Bee

Matt Bee — Thu, 05 Feb 2009 09:59:53 +0000

I use Codeigniter regularly and what I like about it is that I have the option to either cobble together an application in almost no time by adding some PHP direct into the view files, but when I am building a larger app or working with a front end programmer to handle the views I can use the parser class, and all code is removed from the view.

Add to that a set of custom libraries and models to do my dirty work, I end up with either a very clean app, an app that was built in no time, or an app that is both!

Flexibility is the best thing any framework can give a user, from the simplest CSS framework to the biggest MVC framework.

By: Ivan

Ivan — Wed, 28 Jan 2009 14:45:04 +0000

Well, this post has two sides.

On one side we have the MVC pattern which is there for a reason, and sure, we SHOULD remove as much code as possible from our Views. But I think loops aren’t that big of a deal because they only serve to DISPLAY the data.

On the other side, some people argue we should format the output in the Controller and only print it in Views. Sure, this is fine for a CMS, but it doesn’t really make much sense in a real world app which probably will never change it’s design.

We should always stick to the DRY principle, which goes in favor of the second approach. In CakePHP we could make a new method in the AppModel called (e.g.) “formatComments” which would format the look of comments of (e.g.) an article and then pass it as a variable to the View, but it is resource consuming.

I guess it’s all about how much time you have on your hands and what kind of project you’re working on. CMS sites should stick to DRY, others, well, it’s up to you

By: Luke

Luke — Fri, 09 Jan 2009 15:58:20 +0000

I have to disagree with the main point of this post too. I have yet to work with a designer (which should be referred to as an HTML/CSS developer in this case) that couldn’t figure out how to work around and understand php and looping code in CodeIgniter views within about 15 minutes. If I have an HTML/CSS developer working on my HTML templates that can’t grasp what the few PHP tags mean in the super-clean CodeIgniter views then it’s time to find another developer that can

By: bolongsox

bolongsox — Mon, 04 Aug 2008 15:25:09 +0000

If I have to prepare the whole stuff in the controller, then I can scrap the view altogether, and instead of loading view files, just print the html stuff directly from the controller to the browser… but then wasn’t it like the old days of php when you can put the whole thing in ONE script , yes, ONE piece of script :p db connection, queries, html tags, and molasses of if-else and case switches… and it still works as intended as an application.
I know i don’t make any point here , sorry… but here’s the thing :
Using template engine is no different with putting looping code of pure php. Template engine is just another layer of php logic which parses “designer friendly tags” into final presentation. The logic, is still very much the same. template engine tags also has loops, and conditionals, and also prone to be broken by designers. But then, in the case of designers breaking the code, I absolutely believe that when they do so, it’s a sign for me to get their replacement, heheh..
get code aware designer, it won’t hurt the budget that much. If you think that code illiterate designer worth maintaining, ie: they can create venus de milo of web design, keep them, but just switch the work flow.
Let them design their masterpiece, have them weave the html+css beautifully, then let the programmer pour in the necessary code. Works all the time for me, at very least.
I use CI for some time now, and after a dozen plus projects I still see no problem in the way CI’s view works. Lighten up, designers may break code, but coding in php and web is still fun because you can just refresh and see what is going wrong then fix it quickly. compare that to coding in J2ME, no designers, too many devices, programmer does breaking codes, and no nothing you can count on except System.out.println().
“Presentation logic in view is good, business logic in view, bad !! ” ( DHH of RoR, leader of opinionated, pragmatic software… huh ? opinionated what ??? )